-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce the new cs3-python-client library #161
base: master
Are you sure you want to change the base?
Conversation
64d3962
to
a8217ef
Compare
Marking as ready for review given that the code is pretty much complete. Once the build passes, we can review and merge this change. |
Remaining developments:
|
f54a3e7
to
a95b1a1
Compare
a95b1a1
to
4580644
Compare
Following cs3org/cs3-python-client#8 we now pass the whole test suite:
Therefore this is ready to review. |
3f24225
to
e890c08
Compare
The test has been adapted to require xattrs in the stat output
… always guaranteed
Thanks. We are not using this Wopiserver anymore. We have now a fully integrated and tested solution in https://github.com/owncloud/ocis/tree/master/services/collaboration In that solution we are using the go-cs3 bindings like we also use in reva. |
Thanks for the notice, I suspected that indeed. Will be interesting to see how that service evolves and if we could converge too, though from memory the ocis-integrated solution would not include some (non-strictly-wopi) features we use at CERN. |
This PR is to introduce the https://github.com/cs3org/cs3-python-client library contributed by @rawe0.
As part of this, some refactoring and simplification has taken place:
getxattr()
API, as well as the caching recently introduced, as the xattrs are always queried next to a stat call.versioninv
flag on stat, assuming it's always version invariant. Only xroot was able to make a distinction.readfile
that now raises an exception instead ofyield
ing it. Consequently dropped thepeek
logic.@micbar a heads-up about a larger-than-usual change.
Remaining tasks:
cs3client >= 1.1
as requirement