Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track dangling node change in indexing math generation. #1850

Open
shmsong opened this issue Jul 20, 2022 · 1 comment
Open

Track dangling node change in indexing math generation. #1850

shmsong opened this issue Jul 20, 2022 · 1 comment
Assignees
Labels

Comments

@shmsong
Copy link

shmsong commented Jul 20, 2022

🐛 Describe the bug

This issue tracks the code drift related to index reference replay pass, see #1846 (comment) for the original discussion.

A notable difference observed is that all concrete indexing replay results are now free of dangling nodes:
https://github.com/csarofeen/pytorch/blob/devel/torch/csrc/jit/codegen/cuda/lower_index_compute.cpp#L782-L786

Would need to look further into if the dangling node part of loop indexing can be removed or if there are still cases we need to make sure they are added.

Versions

N/A

@shmsong
Copy link
Author

shmsong commented Sep 22, 2022

More detail see #1846 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant