Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sqlite: store payloads/attributes in separate table #267

Merged
merged 2 commits into from
Nov 9, 2023

Conversation

cschleiden
Copy link
Owner

This change adds a new attributes table to the sqlite backend. Serialized attributes for events are stored in that table instead of inline.

Contributes to: #39

@cschleiden cschleiden marked this pull request as ready for review November 4, 2023 00:30
@cschleiden
Copy link
Owner Author

!bench !large

1 similar comment
@cschleiden
Copy link
Owner Author

!bench !large

@cschleiden cschleiden force-pushed the sqlite-attributes branch 2 times, most recently from 3fcac68 to f5e03e9 Compare November 4, 2023 05:30
@cschleiden
Copy link
Owner Author

!bench

@cschleiden
Copy link
Owner Author

!bench !large

Copy link

github-actions bot commented Nov 4, 2023

Default run

Command Mean [ms] Min [ms] Max [ms] Relative
mysql-main 834.5 ± 74.6 723.6 975.9 1.00
mysql-pr 868.6 ± 173.3 608.0 1050.8 1.04 ± 0.23
Command Mean [s] Min [s] Max [s] Relative
sqlite-main 1.057 ± 0.209 0.705 1.309 1.01 ± 0.28
sqlite-pr 1.050 ± 0.207 0.689 1.293 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
redis-main 268.4 ± 41.6 213.0 371.1 1.08 ± 0.20
redis-pr 249.3 ± 25.4 207.0 278.4 1.00

Copy link

github-actions bot commented Nov 4, 2023

Default run

Command Mean [ms] Min [ms] Max [ms] Relative
mysql-main 383.0 ± 64.6 306.1 483.5 1.05 ± 0.22
mysql-pr 363.8 ± 45.7 303.0 476.2 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
sqlite-main 569.4 ± 99.0 444.2 778.2 1.00
sqlite-pr 570.4 ± 110.4 430.5 816.9 1.00 ± 0.26
Command Mean [ms] Min [ms] Max [ms] Relative
redis-main 128.4 ± 15.4 88.9 173.1 1.00
redis-pr 142.5 ± 20.2 123.5 204.6 1.11 ± 0.21

Large payload run (1MB)

Command Mean [s] Min [s] Max [s] Relative
sqlite-main 23.847 ± 0.744 22.488 24.933 1.08 ± 0.05
sqlite-pr 22.127 ± 0.784 20.825 23.013 1.00
Command Mean [s] Min [s] Max [s] Relative
redis-main 22.753 ± 0.770 21.416 23.913 1.00 ± 0.04
redis-pr 22.746 ± 0.522 21.869 23.407 1.00

@cschleiden cschleiden changed the title Store payloads/attributes in separate table Sqlite: store payloads/attributes in separate table Nov 9, 2023
@cschleiden cschleiden merged commit 38a69da into main Nov 9, 2023
4 checks passed
@cschleiden cschleiden deleted the sqlite-attributes branch November 9, 2023 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant