Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: Cannot find module 'env-var' #177

Closed
mcakircali opened this issue Oct 4, 2020 · 7 comments · Fixed by #180
Closed

Error: Cannot find module 'env-var' #177

mcakircali opened this issue Oct 4, 2020 · 7 comments · Fixed by #180
Labels

Comments

@mcakircali
Copy link

Description

#176: change of env to env-var causes failure to load. Is "env-var" now a dependency?

Log

[2020-10-04 08:04:25.261] [exthost] [error] Activating extension cschlosser.doxdocgen failed due to an error:
[2020-10-04 08:04:25.265] [exthost] [error] Error: Cannot find module 'env-var'
Require stack:
- c:\Users\user\.vscode\extensions\cschlosser.doxdocgen-0.8.0\out\Lang\Cpp\CppDocGen.js
- c:\Users\user\.vscode\extensions\cschlosser.doxdocgen-0.8.0\out\Lang\Cpp\CppParser.js
- c:\Users\user\.vscode\extensions\cschlosser.doxdocgen-0.8.0\out\CodeParserController.js
- c:\Users\user\.vscode\extensions\cschlosser.doxdocgen-0.8.0\out\extension.js
- c:\Users\user\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\loader.js
- c:\Users\user\AppData\Local\Programs\Microsoft VS Code\resources\app\out\bootstrap-amd.js
- c:\Users\user\AppData\Local\Programs\Microsoft VS Code\resources\app\out\bootstrap-fork.js```
@cschlosser cschlosser added the bug label Oct 4, 2020
@cschlosser
Copy link
Owner

Yes it is to support #110 .
Have to investigate why it isn't loading.

@cschlosser
Copy link
Owner

I did a test prior to the release where it was loading just fine. Still have the .vsix around. Not sure why the 0.8.0 is now broken.
Can reproduce it though

@cschlosser
Copy link
Owner

cschlosser commented Oct 4, 2020

For some reason the node modules are not packaged.

"Old" extension from my local build yesterday

cschlosser.doxdocgen-0.7.2> ls -al                                                                                           
total 232
drwxr-xr-x  13 christoph  staff    416  4 Okt 11:45 ./
drwxr-xr-x   8 christoph  staff    256  4 Okt 11:47 ../
-rw-r--r--   1 christoph  staff   3121  4 Okt 11:45 .vsixmanifest
-rw-r--r--   1 christoph  staff   6039  4 Okt 11:45 CHANGELOG.md
-rw-r--r--   1 christoph  staff   1090  4 Okt 11:45 LICENSE.txt
-rw-r--r--   1 christoph  staff   9018  4 Okt 11:45 README.md
drwxr-xr-x  13 christoph  staff    416  4 Okt 11:45 coverage/
drwxr-xr-x  26 christoph  staff    832  4 Okt 11:45 images/
drwxr-xr-x   7 christoph  staff    224  4 Okt 11:45 node_modules/
drwxr-xr-x   7 christoph  staff    224  4 Okt 11:45 out/
-rw-r--r--   1 christoph  staff  70750  4 Okt 11:45 package-lock.json
-rw-r--r--   1 christoph  staff   9200  4 Okt 11:45 package.json
-rw-r--r--   1 christoph  staff    149  4 Okt 11:45 tslint.json

VS Code marketplace extension:

cschlosser.doxdocgen-0.8.0>ls -al                                                                                           
total 88
drwxr-xr-x  10 christoph  staff   320  4 Okt 11:31 ./
drwxr-xr-x   8 christoph  staff   256  4 Okt 11:47 ../
-rw-r--r--   1 christoph  staff  3104  4 Okt 11:31 .vsixmanifest
-rw-r--r--   1 christoph  staff  7101  4 Okt 11:31 CHANGELOG.md
-rw-r--r--   1 christoph  staff  1090  4 Okt 11:31 LICENSE.txt
-rw-r--r--   1 christoph  staff  8576  4 Okt 11:31 README.md
drwxr-xr-x  26 christoph  staff   832  4 Okt 11:31 images/
drwxr-xr-x   7 christoph  staff   224  4 Okt 11:31 out/
-rw-r--r--   1 christoph  staff  8966  4 Okt 11:31 package.json
-rw-r--r--   1 christoph  staff   149  4 Okt 11:31 tslint.json

Edit: This can also be observed on the GitHub releases page. The 0.8.0 release is about 1MB smaller in size compared to 0.7.2.

I triggered a revert of the env var commit in the hope that this fixes it. We'll have to see.

@cschlosser
Copy link
Owner

It seems as this is related to vsce.

Could you try it with the 0.8.2 version and give feedback if it works for you now as well please?

@cschlosser cschlosser mentioned this issue Oct 4, 2020
1 task
@cschlosser
Copy link
Owner

cschlosser commented Oct 4, 2020

This is the bug(fix): microsoft/vscode-vsce#495

Even when not using yarn, yarn will be set to true and since yarn doesn't specify dependencies non will be packaged.

@cschlosser
Copy link
Owner

Release 1.0.0 is published and should be working.
Thanks for getting this to my attention so early :)

@mcakircali
Copy link
Author

Release 1.0.0 is published and should be working.
Thanks for getting this to my attention so early :)

I can confirm that it works. Great tool. I thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants