Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctness issue with weekly display #106

Open
blobberim opened this issue Jan 19, 2025 · 6 comments
Open

Correctness issue with weekly display #106

blobberim opened this issue Jan 19, 2025 · 6 comments

Comments

@blobberim
Copy link

Hi, seeing some issue with the weekly display where the task bars are not assigned to the correct weeks (perhaps when spanning a year boundary, week-number issue?)

to reproduce:

roadmap.set_timeline(TimelineMode.WEEKLY, start="2024-11-01", number_of_items=24, show_first_day_of_week=True) 

group = roadmap.add_group("Core Product Work Stream")

group.add_task("Base Functionality", "2024-12-01", "2025-01-05")
group.add_task("Enhancements", "2025-01-06", "2025-03-31")

Even though the second task starts the day after the first one ends, it looks like there is a week in between (show_first_day_of_week False as well):

Image

Windows and Mac, python 3.11, dateutil 2.9.0.post0, Aussie locale settings

@csgoh
Copy link
Owner

csgoh commented Jan 19, 2025

@blobberim Thanks for logging the issue. It is a defect in the code. It will be fixed.

@csgoh
Copy link
Owner

csgoh commented Jan 20, 2025

@blobberim This has now been fixed in v1.5.1.

Image

@blobberim
Copy link
Author

blobberim commented Jan 20, 2025

thanks for quick turnaround, looking good!

Wondered if rich needed to be added to requirements, and also if there should be config options or equiv to set the individual show_ flags in Helper as the output can be quite verbose...

@csgoh
Copy link
Owner

csgoh commented Jan 20, 2025

@blobberim Yeah, I was running out of time yesterday and v1.5.1 was released in a hurry. I will fix it tonight.

@csgoh
Copy link
Owner

csgoh commented Jan 21, 2025

@blobberim the verbose output was meant for debugging. It is now fixed in v1.5.2.

@blobberim
Copy link
Author

hi, sorry to be a pest but it seems the Milestone placement also needs the same fix - a milestone added past the year boundary will appear to jump forward a week past the correct placement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants