Zoom / resolution / dynamic Query - fails to load unloaded data

[oehm-smith]

I saw this issue. Something like - zoom out so MLB comes in to view but far enough out so that the waterbody NE of Geelong is out of the dynamic Query range (see eow-layers.ts, layers.ts). So the waterbody is not shown and the charts are not drawn. Now zoom in to it and theoretically the dynamic query range should now include this and the waterbodies are shown and the charts are drawn. But they aren't.

An easier example. Zoom out 3 clicks from Canberra and then zoom in on wagga where a chart should be drawn.

This is based on commit EO Day 3.3.2020.

[oehm-smith]

Today is my last day of contract and dont have time to fix this. Let me discuss this further.

Firstly I am not seeing this problem now that I've made some other changes. Hopefully it is solved through this. That reproduction recipe above no longer works (that's good). Incase it is still a problem, read on

1. The pie charts stop drawing at a certain zoom out level since with the number of water bodies in view the processing will become computationally intensive and the app stops
2. Another efficiency gain is to limit the features that are retrieved from the server to be only those in the current view (extent)
3. The main one is to limit the waterbody polygon size based on resolution. So theoretically I could kill the 'don't calculate after zoom out too far' If this worked well enough.
4. An extra efficiency is to not calculate and draw a pie chart again once it has already been done. Although this is more about not having the same pie chart on top of itself ie. wasting memorys

Between the three of these I think that the data isn't being pulled in, or the pie chart is not being recalculated (for some reason the code thinks it had been calculated once), or the server thinks the data has already been retrieved and the pie charts are not being drawn.

A slightly painful way to avoid this is to not zoom too far out for nearby EOW Data regions (3 or maybe 4 max).

Again, it looks like this may be fixed.

[oehm-smith]

I reproduced the error.

1. When at the default upon reload (Canberra), zoom out 6. Pie chart generation will stop.
2. Centre on Melbourne and zoom in 2 clicks.
3. Pie charts should be drawn but aren't