Skip to content

File gets included twice when composes a file directly and indirectly #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
madpilot opened this issue Aug 19, 2016 · 4 comments
Closed

Comments

@madpilot
Copy link

The scenario is this:

file a composes a selector from file c and b (in that order)
file b composes a selector from file c

the output includes the source from file c twice (and in an order where the second inclusion will override the selector from b).

I have a failing test case here: https://github.com/madpilot/css-modules-loader-core/tree/master/test/test-cases/mixed-dependencies

@joshwnj
Copy link
Member

joshwnj commented Aug 19, 2016

@madpilot out of interest, does this kind of thing appear to get picked up by any of the postcss optimizers (csso, cssnano)?

@madpilot
Copy link
Author

I haven't tried - I say it would...

I'm looking at it now, I think I have a solution but it looks like it breaks ordering

@joshwnj
Copy link
Member

joshwnj commented Aug 19, 2016

lol even I forgot I did this: #62

@joshwnj
Copy link
Member

joshwnj commented Aug 19, 2016

@madpilot css-modules-loader-core@1.0.1

@joshwnj joshwnj closed this as completed Aug 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants