Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate XMLReader variant of DocumentFactory.createDocument, add setXMLReader #71

Closed
carlosame opened this issue Dec 10, 2022 · 0 comments
Assignees
Labels
deprecation Something was deprecated enhancement New feature or request
Milestone

Comments

@carlosame
Copy link
Member

Interface DocumentFactory in the dom module has the following method variant:

Document createDocument(String ns, String root, String uri, XMLReader r) throws IOException;

which is confusing because only allows the usage of the XMLReader via the document URI retrieval.

That method should be deprecated, and instead a new setXMLReader(XMLReader) could be added. That way, one can specify an XMLReader to be used by the factory, regardless of the chosen input variant (stream, reader or URI retrieval).

@carlosame carlosame added enhancement New feature or request deprecation Something was deprecated labels Dec 10, 2022
@carlosame carlosame added this to the 0.2.2 milestone Dec 10, 2022
@carlosame carlosame self-assigned this Dec 10, 2022
@carlosame carlosame modified the milestones: 0.2.2, 0.3 Dec 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation Something was deprecated enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant