Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme callback called twice #26

Closed
oliviertassinari opened this issue Jul 25, 2017 · 0 comments
Closed

Theme callback called twice #26

oliviertassinari opened this issue Jul 25, 2017 · 0 comments

Comments

@oliviertassinari
Copy link
Contributor

oliviertassinari commented Jul 25, 2017

This issue is part of a series of feedbacks. I been upgrading the Material-UI solution.
Unfortunately, I had to fork the package in order to reach my goal.
Now, it's time to reconciliation.

The issue

I have noticed that a theme callback can be called twice during a first render.
The first time, it's called with a null outer theme.
I think that it can be reproduced with the following:

<ThemeProvider theme={x}>
  <ThemeProvider theme{(x) => { console.log(x) }>
    <div />
  </ThemeProvider>
</ThemeProvider>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant