You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
First of all, thanks a lot for writing and maintaining auraloss -- it is great to have a common package for these functions!
auraloss seems to contain reasonable type annotations, at least for a certain subset of functions.
Unfortunately, the library doesn't ship with a py.typed marker (c.f. PEP 561, which means that type checkers and IDEs don't make use of the type annotations. It would be nice to add a py.typed to really benefit from the type annotations, especially since using type checking is becoming more and more a standard.
If that would be fine I can open a PR to add it, and perhaps also integrate a type check into the CI, and extend the existing type annotations a little bit. What do you think?
The text was updated successfully, but these errors were encountered:
First of all, thanks a lot for writing and maintaining
auraloss
-- it is great to have a common package for these functions!auraloss
seems to contain reasonable type annotations, at least for a certain subset of functions.Unfortunately, the library doesn't ship with a
py.typed
marker (c.f. PEP 561, which means that type checkers and IDEs don't make use of the type annotations. It would be nice to add apy.typed
to really benefit from the type annotations, especially since using type checking is becoming more and more a standard.If that would be fine I can open a PR to add it, and perhaps also integrate a type check into the CI, and extend the existing type annotations a little bit. What do you think?
The text was updated successfully, but these errors were encountered: