Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split words before searching #196

Closed
wants to merge 2 commits into from
Closed

Split words before searching #196

wants to merge 2 commits into from

Conversation

Matthijsy
Copy link
Contributor

Summary

This PR splits every search term and will search for it on every field. This makes it possible to search on first name and last name in the same query

Fixes #194

wilco375
wilco375 approved these changes Feb 17, 2021
View reviewed changes
Copy link
Contributor

@wilco375 wilco375 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Matthijsy Matthijsy closed this Mar 10, 2021
@DrumsnChocolate
Copy link
Contributor

was this ever actually merged into staging?

@wilco375
Copy link
Contributor

Looks like it was closed without merging for some reason. @Matthijsy ?

@Matthijsy
Copy link
Contributor Author

Yes this did not work, had to implement it differently

@wilco375 wilco375 deleted the hotfix/multisearch branch February 9, 2022 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wilco375 wilco375 wilco375 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Members search function doesn't function intuitively
3 participants
@Matthijsy @DrumsnChocolate @wilco375