Contact button doesn't change colors when scrolling to it.

[abelsonlive]

[tlevine]

This happens because the "Contact" section heading isn't quite at the top of the page. We could set an offset for the scrollspy, but it looks like the offset option doesn't work in Bootstrap scrollspy. We could fix scrollspy, write something custom to deal with this spying, do some hack like giving the footer a big margin or just ignore it for now. (Or maybe there are other options.)

[mhkeller]

We could make examples the last section, which would be long enough to trigger the spy. I think setting an offset for contacts would mess up the other sections.

Le Jul 1, 2013 à 1:24, Thomas Levine notifications@github.com a écrit :

This happens because the "Contact" section heading isn't quite at the top of the page. We could set an offset for the scrollspy, but it looks like the offset option doesn't work in Bootstrap scrollspy. We could fix scrollspy, write something custom to deal with this spying, do some hack like giving the footer a big margin or just ignore it for now. (Or maybe there are other options.)

—
Reply to this email directly or view it on GitHub.

[mhkeller]

Fixed by making custom offset for the contact section csvsoundsystem/treasury.io@ 30df93f548f8f382746a9d2e8dc0e1684c2f4d55

[mhkeller]

Disabled that hack for now since it only works at certain browser widths. Looking into a solution that works no matter the browser width.

[tlevine]

This doesn't seem too important, especially considering that we haven't worked on it in a month. I'm moving it to dreams.