Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ODL geometry interfaces #2

Open
adler-j opened this issue May 5, 2019 · 1 comment
Open

ODL geometry interfaces #2

adler-j opened this issue May 5, 2019 · 1 comment

Comments

@adler-j
Copy link

adler-j commented May 5, 2019

Hello! I just found out about this library and I'm very optimistic about it.

So far most implementations have used something like the as_tensorflow_layer in ODL which calls ASTRA as a backend to get CUDA accelerated projections.

ODL already has rather thought out geometry objects that should be convertible to PYRO-NN geometries. This would allow seamless testing and integration between the framework, e.g. doing a TV reconstruction in ODL and training with PYRO-NN. It would also allow us to validate each others implementations and perform benchmarks.

@csyben
Copy link
Owner

csyben commented May 6, 2019

Hello,
i was planning to contact you either way :).

I think that's a great idea, we definitely should do that. It should be pretty straight forward to bring the PRYO-NN-Layers to ODL. I think we have to ensure that we find all minor differences, or implicit assumptions (e.g. For the 3D projection matrices we assume a normalization such that the last entry is 1, also the channel handling could be a minor obstacle, etc.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants