Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Free scipy version whenever we update lstchain to a new gammapy release #1202

Open
rlopezcoto opened this issue Jan 22, 2024 · 2 comments
Open

Comments

@rlopezcoto
Copy link
Contributor

#1201 limits scipy to version before 1.12 due to a breaking change solved in gammapy main branch. Let us fix scipy version until there is a gammapy release

@morcuended
Copy link
Member

I think scipy was pinned before the release of Gammapy 1.2. Now there is even Gammapy v1.3 out. We do not depend very much on it in the codebase, but especially for some high-level analysis notebooks, we made some changes to adapt to the newer versions 1.2/1.3 and might not work with Gammapy 1.1. The problem is that people may still use older versions, so I'm not sure whether to change the Gammapy version required >=1.2.

@rlopezcoto
Copy link
Contributor Author

maybe we can adapt lstchain to work with gammapy v1.3 and make a new major release (v0.11)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants