Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is get_selected_pixels from DVR equivalent to zero_suppression_tailcut_dilation? #1323

Open
vuillaut opened this issue Dec 4, 2024 · 1 comment

Comments

@vuillaut
Copy link
Member

vuillaut commented Dec 4, 2024

Function get_selected_pixels selects pixels above T pixels and keeps N rounds of pixels around.
Could we use the existing function zero_suppression_tailcut_dilation with parameters

number_of_dilation = 1
picture_thresh = 8
boundary_thresh = -inf
keep_isolated_pixels = True
min_number_picture_neighbors = 0

?

@moralejo
Copy link
Collaborator

moralejo commented Dec 5, 2024

I think boundary should be +inf, and then, to keep the same behaviour, one would have to keep the whole camera if the number of surviving pixels is above a threshold (500 by default).
The algo is very simple, so I am not sure it pays to use more generic functions - with the additional calls, wouldn't it be slower?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants