-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subarrays, allowed_tels
and the Stereo Trigger
#1624
Comments
Are there events with less than 2 triggering telescopes in Prod5? I would say that until the mono-reconstruction is not in ctapipe, any single-telescope-triggered event (if any) should be recorded and filled with proper image parameters and NaN reconstruction values. |
@HealthyPear the problem are not events with less than 2 triggering telescopes in the full array, but there will for sure be events that would never have triggered certain subarrays. And I was wondering if that is as easy as "check there are at least two telescopes in the selected subarray" or if we would somehow redo the stereo trigger for the selected subarray. |
Why do you have to check it before? This will be catched automatically by the call of any reconstructor, by filling with nan the appropriate containers if the length of the hillas dictionary is <2 so whatever the subarray these events should go through the pipeline anyhow, get calibrated, cleaned and parametrized and not reconstructed if that's the case am I missing a deeper problem? |
Yes, a conceptional problem that an event source should not yield events that would not have triggered the selected subarray. |
so the case you are talking about is the whole subarray? not even 1 telescope? |
We simulate more telescopes then realistic arrays will have to be able to optimize the layout. What I want to discuss here is how that decision (simulating more telescopes) affects the stereo trigger and if there is something we need to do about the triggering when selecting only a subarray of all the simulated telescopes. If the answer is "Just check there are at least two triggered telescopes after you selected the subarray", that is simple. But normally, these trigger decisions are not as simple and we might create biases by using the stereo trigger of the super-array for analysis of a sub-array. |
This is what we have done in the past when processing CTA MC productions, in which a minimum of "any 2 telescopes" from the super-array was required to write out an event. |
@moralejo ok, but that is not an issue anymore for Prod5, right? Since only 4 LSTs are simulated. So at least for prod5, requiring at least two telescopes is enough? |
No, because in the simtel file you may have events with 1 LST and xxx MSTs. In those events you still have to remove the LST (wouldn't be there in the real data). |
Hi @moralejo, |
Ok, I didn't realize that this is not implemented at all in the simulation. I thought this problem only arises when removing LSTs that might have contributed. |
Yes, in the simulation it is "any 2 telescopes". |
@moralejo coming back to this, so the correct algorithm would be:
Anything else? |
@GernotMaier I am wondering if this might be the reason for the remaining difference of the sensitivity from pyirf and EventDisplay. How does EventDisplay treat these kinds of Events? And how are they included in the exported DL2 fits files? |
The DL2 contains all events with at least 2 telescopes of each type in a given subarray. e.g., for a LST + MST array, it could be:
Events which are in the simulation files, but which do not fulfill any of these criteria are considers as 'no trigger'. And yes, one could allow 1 LST + 1 MST events, or even 1 LST or 1 MST only. The work on even types and corresponding reconstruction quality should take care of the differences in precision. |
My question was if you removed those "invalid" Events for the sensitivity calculation of event display. 1 + 1 would not be a problem, since you require a multiplicity of 4 (now 3?), but do you remove single LST telescope events? |
Yes. It does not fulfill the condition >=2 for at least one telescope type in the subarray. |
Sorry, overread the "of each telescope type" part. |
So the cut is just accept if any telescope type has 2 or more telescopes, including cases where there is a single telescope of a single type? @GernotMaier is there a reason for the 2 of the same type criterion? Is there a problem with just a straight multiplicity cut? I would not think it could cause any problems to have an event with 1 LST + 1 MS; It should reconstruct fine, as long as they are calibrated properly. |
If I understood correctly, the real stereo trigger requires at least two LSTs for an LST event to be read out. So the real CTA will never have this kind of event. Which means they shouldn't enter sensitivity calculations. |
No reason (except lazy implementation of reconstruction algorithms) - we should look at e.g., 1 MST + 1 SST events. |
But according to @moralejo the LST should be removed from such events, right? |
as far as I understood,
same for CTAS. images are remove / not considered even before shower geometry I guess? |
I think it should only happen just before combining telescopes to form stereo predictions (either geometric or by combining the ML mono outputs). There is no real benefit of removing them already at the dl1 level and especially for super-array simulation, you want to keep then and then decide at the DL2 level for a specific subarray. |
by "before" shower geometry I meant you record the DL1b data for those to-be-discarder images, but then you don't use them to e.g. estimate the direction or impact parameter unless I misunderstood what you mean (you fix the images when you use the to estimate the shower geometry which is anyway the first DL2 step) |
No, the last one is wrong. Al three telescopes are kept. There is no hardware stereo for the MST array. |
I am getting more and more confused by this discussions. In the simulations, we have the following trigger conditions:
So why do we need to remove events on the analysis level, unless there is software trigger condition foreseen to remove 1 MST events even when there was a valid LST trigger. |
Hi @GernotMaier, at least at some point the trigger condition in the simulations was "any 2 telescopes", and this required to do this, so that no isolated LSTs were allowed in any event. |
OK - I guess we anyway have to wait for the exact trigger settings. I guess MST trigger rates are anyway on the high site for the prod3b/prod5 simulations and we might expect changes in the trigger threshold after we have experience with the first telescopes. |
This is now possible using the |
This is a an issue concerning the selection of subarrays from the simulated super-arrays.
How do we need to take the stereo trigger into account here?
E.g. what should happen if we select an event that would have less than 2 telescopes triggered in the set of selected telescopes?
The text was updated successfully, but these errors were encountered: