Skip to content
This repository has been archived by the owner on Apr 16, 2020. It is now read-only.

Does SourceLink work with local non-indexed pdb files? #79

Closed
dungpa opened this issue Jun 7, 2015 · 5 comments
Closed

Does SourceLink work with local non-indexed pdb files? #79

dungpa opened this issue Jun 7, 2015 · 5 comments

Comments

@dungpa
Copy link

dungpa commented Jun 7, 2015

Context

I prototype a feature in VFPT that uses pdb files to go to a symbol in C# project. It would be a compelling case for using SourceLink because that part isn't supported by FSharp.Compiler.Service.

I have had all the bits wired up correctly. You can see the prototype at https://github.com/dungpa/PowerTools/tree/go-to-csharp-project.

Results

To my surprise, SourceLink returns garbled results when reading local non-indexed pdb files of C# projects. I also make a test using your console program, no difference. You can see the test at https://gist.github.com/dungpa/7504c7633a613ba59d04. Most of the time, SourceLink points to wrong locations. Sometimes, it even points to wrong files.

Questions

Should SourceLink support local non-indexed pdb files? Or did I miss something to get this working?

@ctaggart
Copy link
Owner

ctaggart commented Jun 8, 2015

The original design of SourceLink.SymbolStore was to support source indexed pdb files. Supporting pdb files that are not indexed sounds reasonable.

@dungpa
Copy link
Author

dungpa commented Jun 8, 2015

Do you plan to support this use case soon?

It is a common use case since most of C# projects in a mixed C#/F# solution has pdb files for use. This would be a great showcase for SourceLink in the area of design-time tooling.

@dungpa
Copy link
Author

dungpa commented Jun 26, 2015

@ctaggart Have you seen this https://twitter.com/ploeh/status/614328824969490432? People start to notice SourceLink :-)

@ctaggart
Copy link
Owner

👍

@ctaggart ctaggart added this to the 0.7.0 milestone Jun 29, 2015
@ctaggart ctaggart removed this from the 1.1.0 milestone Aug 24, 2015
@ctaggart
Copy link
Owner

The Portable PDB format solves these issues. See details in #93. I think the the Microsoft teams will start shipping them and everyone will probably follow suit.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants