Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to latest version of gRPC #284

Closed
scholarsmate opened this issue Jun 29, 2022 · 2 comments · Fixed by #394
Closed

Upgrade to latest version of gRPC #284

scholarsmate opened this issue Jun 29, 2022 · 2 comments · Fixed by #394
Assignees
@scholarsmate
Labels
C++ dependencies Pull requests that update a dependency file grpc gRPC server
Milestone
v1.0.0

Comments

@scholarsmate
Copy link
Member

Ωedit is currently on v1.45.2 and the most recent version is 1.47.0, which is a fairly big release, plus what's been developed in 1.46.x. Unfortunately, v1.45.2 is the most recent gRPC version available in conan.io.
@scholarsmate scholarsmate added the dependencies Pull requests that update a dependency file label Jun 29, 2022
@scholarsmate scholarsmate added this to the v1.0.0 milestone Jun 29, 2022
@scholarsmate scholarsmate self-assigned this Jun 29, 2022
@scholarsmate scholarsmate added wontfix This will not be worked on labels Jul 11, 2022
@scholarsmate
Copy link
Member Author

Conan.io now has more recent versions of gRPC available, but protocol buffers no longer bundles the JS code code generator (see: protocolbuffers/protobuf-javascript#127). The code generator was moved to this repo https://github.com/protocolbuffers/protobuf-javascript, and there haven't been any releases, nor has there been much activity. We'll stick with 1.45.2 until there is a straightforward upgrade path.

Repository owner moved this from Todo to Done in OmegaEdit and VSCode Plugin Jul 11, 2022
@scholarsmate scholarsmate reopened this Sep 13, 2022
Repository owner moved this from Done to In Progress in OmegaEdit and VSCode Plugin Sep 13, 2022
@scholarsmate scholarsmate linked a pull request Sep 13, 2022 that will close this issue
upgrade grpc #394
Merged
@scholarsmate
Copy link
Member Author

JavaScript/TypeScript code generation is being done with node packages and does not require the plugin from gRPC core. conan.io now has gRPC 1.48.0, so the upgrade is now possible.

@scholarsmate scholarsmate mentioned this issue Sep 13, 2022
Merged
@scholarsmate scholarsmate added grpc gRPC server C++ and removed wontfix This will not be worked on labels Sep 13, 2022
@scholarsmate scholarsmate moved this from In Progress to In Review in OmegaEdit and VSCode Plugin Sep 13, 2022
Repository owner moved this from In Review to Done in OmegaEdit and VSCode Plugin Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scholarsmate scholarsmate

Labels
C++ dependencies Pull requests that update a dependency file grpc gRPC server
Projects
OmegaEdit and VSCode Plugin
Status: Done
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

upgrade grpc ctc-oss/omega-edit
1 participant
@scholarsmate