Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve detection of encrypted config values (by also scanning system.xml and children) #133

Open
rutgerrademaker opened this issue Nov 14, 2023 · 0 comments

Comments

@rutgerrademaker
Copy link

In https://github.com/ctidigital/magento2-configurator/blob/develop/Component/Config.php#L178 we can see the config path is matched against values in the metaData

The metadata however only seems to check a module's config.xml

https://github.com/magento/magento2/blob/2.4-develop/lib/internal/Magento/Framework/App/Config/Initial/Reader.php#L72

Many (third party) modules use config files in app/etc/adminhtml/system.xml (and children) to declare the backend_model to be using Magento\Config\Model\Config\Backend\Encrypted

E.g:

https://github.com/Adyen/adyen-magento2/blob/develop/etc/adminhtml/system/adyen_initial_setup.xml#L47
https://github.com/buckaroo-it/Magento2/blob/master/etc/adminhtml/system/account.xml#L40

Currently these fields are not detected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant