Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

annotate -r annotates more than just route.rb #306

Closed
rhuppert opened this issue Dec 31, 2015 · 4 comments
Closed

annotate -r annotates more than just route.rb #306

rhuppert opened this issue Dec 31, 2015 · 4 comments
Assignees
Labels
Milestone

Comments

@rhuppert
Copy link

I recently updated to 2.7.0 and upon running annotate -r, I was surprised when helpers and controllers no included annotations. I suspected the auto_annotate_models rake file was to blame, but even after marking unwanted default annotations false, it made no difference. A message saying models and routes have not changed, but controllers and their spec files and helpers had been modified.

Running Rails 4.2.5, Ruby 2.2.3

@ctran
Copy link
Owner

ctran commented Dec 31, 2015

This is due to #299. Is it just a surprise or you don't find this useful?

I noted this in the release notes.

@rhuppert
Copy link
Author

rhuppert commented Jan 1, 2016

It certainly was a surprise, since the readme indicates the -r argument annotates routes.rb with the output of 'rake routes.' My assumption would be only the route file would be affected.

I should point out that the default behavior cannot be changed with respect to these new annotations' position in the file. I prefer after my code, not before.

I can only speak for myself, but my preference would be to explicitly create that output and not have it happen automatically. Perhaps being able to change the default behavior would be acceptable, but for me I do not find this particularly useful.

Happy New Year.

@ctran ctran added the bug label Jan 1, 2016
@ctran ctran added this to the v2.7.1 milestone Jan 1, 2016
@ctran ctran self-assigned this Jan 1, 2016
@ctran
Copy link
Owner

ctran commented Jan 11, 2016

These are no longer annotated by default (develop branch).

@ctran ctran closed this as completed Jan 11, 2016
@rhuppert
Copy link
Author

Thanks, Cuong. I appreciate the work you do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants