Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make with_comment_column work with Annotate.set_defaults #990

Closed
Adeynack opened this issue Jun 26, 2023 · 7 comments · Fixed by #999
Closed

Make with_comment_column work with Annotate.set_defaults #990

Adeynack opened this issue Jun 26, 2023 · 7 comments · Fixed by #999
Assignees
Labels

Comments

@Adeynack
Copy link
Contributor

Describe your problem here.

Commands

$ rake annotate_models

Acceptance Criteria

  • "with_comment_column" => "false" appears after "with_comment" => "false" when calling rails generate annotate:install.
  • its setting is read when annotating (right now, setting it to true does not activate the switch and comment column is not rendered).

Related Issues

This was an oversight when implementing #988.

@Adeynack
Copy link
Contributor Author

@ctran : You can assign me on this. I will work to fix it.

@ctran
Copy link
Owner

ctran commented Jun 26, 2023

Thanks

@sureshc
Copy link

sureshc commented Nov 9, 2023

Any progress on this? We have a few long table column comments and having this option work with .set_defaults would make the annotations more readable. We can't really turn on with_comment because of the formatting.

@Adeynack
Copy link
Contributor Author

To be 💯 honest, that slipped my mind completely. But I'll resume my effort here, especially if it can make other's life easier! Thanks for the reminder ;-)

@sureshc
Copy link

sureshc commented Nov 13, 2023

To be 💯 honest, that slipped my mind completely. But I'll resume my effort here, especially if it can make other's life easier! Thanks for the reminder ;-)

Thank you so much. We very much appreciate this gem.

@Adeynack
Copy link
Contributor Author

@sureshc @ctran : If I am not mistaken, #999 should do the trick :-)

@Adeynack
Copy link
Contributor Author

@ctran : When can we expect a release with this feature added? 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants