Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

添加自定义灰度，不单单依靠IP来推送灰度规则 #2932

Closed
linking12 opened this issue Feb 25, 2020 · 3 comments · Fixed by #4013
Closed

添加自定义灰度，不单单依靠IP来推送灰度规则 #2932

linking12 opened this issue Feb 25, 2020 · 3 comments · Fixed by #4013
Labels
discussion Categorizes issue as related to discussion feature request Categorizes issue as related to a new feature.

Comments

@linking12
Copy link

Is your feature request related to a problem? Please describe.
由于根据IP来推送灰度规则的话在容器化时不准确，因为IP总是变化（重启后IP就变化了）

Describe the solution you'd like
自定义一个标记位来推送灰度规则

Describe alternatives you've considered
自定义一个标记位来推送灰度规则

Additional context
Add any other context or screenshots about the feature request here.
@nobodyiam nobodyiam added the discussion Categorizes issue as related to discussion label Feb 29, 2020
@nobodyiam
Copy link
Member

是否有建议的实现思路？

@VLoye
Copy link

VLoye commented Mar 5, 2020

是否可以给每个client添加一个客户端标记的配置来绑定灰度规则呢？

@nobodyiam nobodyiam mentioned this issue Mar 14, 2020
Closed
@nobodyiam nobodyiam added the feature request Categorizes issue as related to a new feature. label Mar 14, 2020
@nobodyiam nobodyiam mentioned this issue Jan 7, 2021
Closed
@nobodyiam
Copy link
Member

nobodyiam commented Jan 30, 2021 •
edited
Loading

可以尝试的思路：

  1. 灰度规则增加自定义标签配置能力，IP 和 AppId 抽象为系统默认标签
  2. 一条规则中的多个标签之间是 AND 的关系，比如同时配置了 ip 和 自定义标签，那么需要同时满足所有条件才能匹配上
  3. 之前私有 namespace 只有一条规则，需要扩展为支持多条规则，和公共 namespace 一样，多条规则之间是 OR 的关系
  4. 客户端定义自定义标签规范，可以从文件、system properties、system env 等多种途径获取标签的值
  5. config service 基于客户端的标签信息计算灰度匹配结果

@nobodyiam nobodyiam mentioned this issue Jun 5, 2021
Closed
zcy1010 added a commit to zcy1010Apollo/apollo that referenced this issue Oct 5, 2021
@zcy1010
feature:expands grayscale publishing capabilities to support dimensio…
92db561 
…ns other than IP

fix apolloconfig#2932
@zcy1010 zcy1010 mentioned this issue Oct 5, 2021
Merged
5 tasks
zcy1010 added a commit to zcy1010Apollo/apollo that referenced this issue Oct 6, 2021
@zcy1010
feature:expands grayscale publishing capabilities to support dimensio…
6e98ec6 
…ns other than IP

fix apolloconfig#2932
zcy1010 added a commit to zcy1010Apollo/apollo that referenced this issue Oct 6, 2021
@zcy1010
feature:expands grayscale publishing capabilities to support dimensio…
bcbd03d 
…ns other than IP

fix apolloconfig#2932
zcy1010 added a commit to zcy1010Apollo/apollo that referenced this issue Oct 7, 2021
@zcy1010
feature:expands grayscale publishing capabilities to support dimensio…
bcc4d68 
…ns other than IP

fix apolloconfig#2932
zcy1010 added a commit to zcy1010Apollo/apollo that referenced this issue Oct 7, 2021
@zcy1010
feature:expands grayscale publishing capabilities to support dimensio…
4f52a1f 
…ns other than IP

fix apolloconfig#2932
zcy1010 added a commit to zcy1010Apollo/apollo that referenced this issue Oct 7, 2021
@zcy1010
feature:expands grayscale publishing capabilities to support dimensio…
1330efd 
…ns other than IP

fix apolloconfig#2932
nobodyiam pushed a commit that referenced this issue Oct 9, 2021
@zcy1010
feature:expands grayscale publishing capabilities to support dimensio… (
67a78ef 
#4013)

* feature:expands grayscale publishing capabilities to support dimensions other than IP
fix #2932

* feature:expands grayscale publishing capabilities to support dimensions other than IP
fix #2932

* feature:expands grayscale publishing capabilities to support dimensions other than IP
fix #2932

* feature:expands grayscale publishing capabilities to support dimensions other than IP
fix #2932

* feature:expands grayscale publishing capabilities to support dimensions other than IP
fix #2932

* feature:expands grayscale publishing capabilities to support dimensions other than IP
fix #2932

* Merge branch 'master' into zcy

# Conflicts:
#	CHANGES.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion Categorizes issue as related to discussion feature request Categorizes issue as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feature:expands grayscale publishing capabilities to support dimensio… zcy1010Apollo/apollo
3 participants
@nobodyiam @linking12 @VLoye