-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support displaying configs only to team members #1531
Support displaying configs only to team members #1531
Conversation
…rs could control this behavior by configuring configView.memberOnly.envs in ApolloPortalDB.ServerConfig.
6612ba9
to
1794d3d
Compare
Codecov Report
@@ Coverage Diff @@
## master #1531 +/- ##
===========================================
- Coverage 48.86% 48.7% -0.17%
- Complexity 1893 1895 +2
===========================================
Files 393 393
Lines 11435 11484 +49
Branches 1176 1187 +11
===========================================
+ Hits 5588 5593 +5
- Misses 5419 5463 +44
Partials 428 428
Continue to review full report at Codecov.
|
只有添加某个用为项目管理员,这个用户登录的时候才能看到项目,但是添加成管理员以后,用户就对这个项目的所有配置都能查看了。 我现在的解决办法先添加管理员,然后用这个用户去登录查看一下项目,这时在最近访问列表就能看到项目了,然后把这个用户从项目管理员列表删除,然后分配namespace的权限来控制它的访问权限。 有啥其他的解决办法么?或者后期会不会优化这块的逻辑? configView.memberOnly.envs这个配置我的理解应该是能够达到效果的,但是问题在于不添加管理员账户就无法查看项目,项目只有管理员权限么? |
其他用户可以通过页面上方的搜索功能找到项目 |
多个项目共用一套数据库连接配置,如何操作? 如果是公用namespace,里面的配置,可共享给所有项目,但所有人可见,不安全。 |
数据库连接这类配置还是建议加密存储,在sdk层做解密后去连接数据库。 |
在我的生产环境中遇到了跟 @funlake 一样的问题,我现在要为每个项目单独新建一个私有的namespace来管理这些私密的账号信息,还有各类的授权。确实比较繁琐。 |
@kikupotter 这块可以考虑增加单独的查看权限来实现,不过在结合公共namespace的时候可能会有些问题,还得仔细考虑一下,如果有好的建议也欢迎提出~ |
Purpose
To support displaying configs only to team members for some specific environments.
For some configs such as database connection strings, users would like to make them hidden from non-team members, especially in production environment.
Brief Changes
configView.memberOnly.envs
to config which environments should hide private namespace configs from non-team memebers.configView.memberOnly.envs
, only super admin, app admin and those who have either modification or release permissons can see private namespace configs and release histories.Usage
Simply config
configView.memberOnly.envs
in system configuration page(/server_config.html).And non-team member will see the following page: