Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Community Governance Proposal #3670

Merged
merged 10 commits into from
May 15, 2021

Conversation

nobodyiam
Copy link
Member

Apollo has now been widely adopted in hundreds (if not thousands) of companies, which in my opinion is because we have made great efforts in product quality and user support.

However, as the old saying goes: "If you want to go fast, go alone. If you want to go far, go together.", to make Apollo go further, we now need to put more efforts in community side so that more people could join us and hence make the community stronger.

As another saying goes: "Nothing can be accomplished without norms or standards", so I think the first thing is to define our community governance rules in order to make it clear who we are, how we make decisions so that people could understand and join us without concerns.

The initial governance rules are drafted in this pull request and I wish they could be fully reviewed. So no matter you are a user/contributor/committer, please help to review and feel free to comment if you have any suggestion/idea/question.

Copy link
Member

@kezhenxu94 kezhenxu94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what I've been looking forward to, hope we can built an active community!

GOVERNANCE.md Show resolved Hide resolved
GOVERNANCE.md Outdated Show resolved Hide resolved
GOVERNANCE.md Show resolved Hide resolved
GOVERNANCE.md Outdated Show resolved Hide resolved
GOVERNANCE.md Outdated Show resolved Hide resolved
nobodyiam and others added 2 commits May 10, 2021 08:08
Co-authored-by: Zhenxu Ke <kezhenxu94@apache.org>
Co-authored-by: Zhenxu Ke <kezhenxu94@apache.org>
GOVERNANCE.md Outdated Show resolved Hide resolved
nobodyiam and others added 2 commits May 10, 2021 08:20
Co-authored-by: Zhenxu Ke <kezhenxu94@apache.org>
JaredTan95
JaredTan95 previously approved these changes May 10, 2021
kezhenxu94
kezhenxu94 previously approved these changes May 10, 2021
GOVERNANCE.md Outdated Show resolved Hide resolved
@nobodyiam nobodyiam dismissed stale reviews from kezhenxu94 and JaredTan95 via d942282 May 10, 2021 05:50
GOVERNANCE.md Show resolved Hide resolved
GOVERNANCE.md Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented May 15, 2021

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@nobodyiam
Copy link
Member Author

I have read the CLA Document and I hereby sign the CLA

Copy link
Member

@zouyx zouyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #3670 (72bdbfb) into master (eb6f0c5) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3670      +/-   ##
============================================
- Coverage     50.99%   50.96%   -0.03%     
+ Complexity     2331     2330       -1     
============================================
  Files           449      449              
  Lines         14026    14026              
  Branches       1426     1426              
============================================
- Hits           7153     7149       -4     
- Misses         6388     6391       +3     
- Partials        485      486       +1     
Impacted Files Coverage Δ Complexity Δ
...lo/configservice/util/InstanceConfigAuditUtil.java 74.35% <0.00%> (-1.71%) 15.00% <0.00%> (ø%)
.../apollo/internals/RemoteConfigLongPollService.java 77.10% <0.00%> (-1.21%) 28.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb6f0c5...72bdbfb. Read the comment docs.

@JaredTan95
Copy link
Member

I have read the CLA Document and I hereby sign the CLA

@JaredTan95
Copy link
Member

recheck

Copy link
Member

@JaredTan95 JaredTan95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JaredTan95 JaredTan95 merged commit d60bf88 into apolloconfig:master May 15, 2021
@github-actions github-actions bot locked and limited conversation to collaborators May 15, 2021
@nobodyiam nobodyiam deleted the add-community-governance branch May 15, 2021 10:02
@nisiyong
Copy link
Member

I have read the CLA Document and I hereby sign the CLA

@nobodyiam nobodyiam added this to the 1.9.0 milestone May 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants