Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistency in how Windows platform is called in different places inside of meta.json #30

Open
dsavenko opened this issue Apr 10, 2017 · 2 comments
Open

Inconsistency in how Windows platform is called in different places inside of meta.json #30

dsavenko opened this issue Apr 10, 2017 · 2 comments
Labels
enhancement

Comments

@dsavenko
Copy link
Contributor

dsavenko commented Apr 10, 2017 •
edited
Loading

Hi,

In only_for_host_os_tags and only_for_target_os_tags Windows has to be defined as windows. In soft_file Windows has to be defined as win.

Better have the same value everywhere.
@gfursin
Copy link
Member

gfursin commented Apr 10, 2017

Yes, I noticed that too - this is my fault (originally I was using win to be short, but then started using windows). We should agree on one and add backward compatible support to check for both "win" and "windows" ...

@dsavenko
Copy link
Contributor Author

OK, I will provide a PR when I finish with higher priority tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dsavenko @gfursin