Skip to content

Commit 20ab491

Browse files
committed
chore(schema-compiler): improvement in extractFilterMembers
1 parent 933da82 commit 20ab491

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

packages/cubejs-schema-compiler/src/adapter/BaseQuery.js

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2336,7 +2336,7 @@ export class BaseQuery {
23362336

23372337
/**
23382338
* Evaluate escaped SQL-alias for cube or cube's property
2339-
* (measure, dimention).
2339+
* (measure, dimension).
23402340
* @param {string} cubeName
23412341
* @returns string
23422342
*/
@@ -3494,9 +3494,13 @@ export class BaseQuery {
34943494
static extractFilterMembers(filter) {
34953495
if (filter.operator === 'and' || filter.operator === 'or') {
34963496
return filter.values.map(f => BaseQuery.extractFilterMembers(f)).reduce((a, b) => ((a && b) ? { ...a, ...b } : null), {});
3497-
} else if (filter.measure || filter.dimension) {
3497+
} else if (filter.measure) {
34983498
return {
3499-
[filter.measure || filter.dimension]: true
3499+
[filter.measure]: true
3500+
};
3501+
} else if (filter.dimension) {
3502+
return {
3503+
[filter.dimension]: true
35003504
};
35013505
} else {
35023506
return null;

0 commit comments

Comments
 (0)