Skip to content

Commit e0a493f

Browse files
committed
fix/correct test comments
1 parent 09fcec7 commit e0a493f

File tree

1 file changed

+10
-15
lines changed

1 file changed

+10
-15
lines changed

packages/cubejs-schema-compiler/test/integration/postgres/cube-views.test.ts

Lines changed: 10 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -450,18 +450,16 @@ view(\`OrdersSimpleView\`, {
450450

451451
it('verify drill member inheritance functionality', async () => {
452452
await compiler.compile();
453-
453+
454454
// Check that the source Orders cube has drill members
455455
const sourceOrdersCube = metaTransformer.cubes.find(c => c.config.name === 'Orders');
456456
const sourceCountMeasure = sourceOrdersCube.config.measures.find((m) => m.name === 'Orders.count');
457457
expect(sourceCountMeasure.drillMembers).toEqual(['Orders.id', 'Orders.createdAt']);
458-
458+
459459
// Check that the OrdersView cube inherits these drill members with correct naming
460460
const viewCube = metaTransformer.cubes.find(c => c.config.name === 'OrdersView');
461461
const viewCountMeasure = viewCube.config.measures.find((m) => m.name === 'OrdersView.count');
462-
463-
// Before our fix, this would have been undefined or empty
464-
// After our fix, drill members are properly inherited and renamed to use the view naming
462+
465463
expect(viewCountMeasure.drillMembers).toBeDefined();
466464
expect(Array.isArray(viewCountMeasure.drillMembers)).toBe(true);
467465
expect(viewCountMeasure.drillMembers.length).toBeGreaterThan(0);
@@ -472,30 +470,27 @@ view(\`OrdersSimpleView\`, {
472470
it('check drill member inheritance with limited includes in OrdersSimpleView', async () => {
473471
await compiler.compile();
474472
const cube = metaTransformer.cubes.find(c => c.config.name === 'OrdersSimpleView');
475-
473+
476474
if (!cube) {
477475
throw new Error('OrdersSimpleView not found in compiled cubes');
478476
}
479-
477+
480478
const countMeasure = cube.config.measures.find((m) => m.name === 'OrdersSimpleView.count');
481-
479+
482480
if (!countMeasure) {
483481
throw new Error('OrdersSimpleView.count measure not found');
484482
}
485-
483+
486484
// Check what dimensions are actually available in this limited view
487485
const availableDimensions = cube.config.dimensions?.map(d => d.name) || [];
488-
489-
// This view only includes ['id', 'createdAt', 'count'] - should have both id and createdAt
486+
487+
// This view only includes 'createdAt' dimension and should not include id
490488
expect(availableDimensions).not.toContain('OrdersSimpleView.id');
491489
expect(availableDimensions).toContain('OrdersSimpleView.createdAt');
492-
490+
493491
// The source measure has drillMembers: ['Orders.id', 'Orders.createdAt']
494492
// Both should be available in this view since we explicitly included them
495493
expect(countMeasure.drillMembers).toBeDefined();
496-
expect(Array.isArray(countMeasure.drillMembers)).toBe(true);
497-
expect(countMeasure.drillMembers.length).toBeGreaterThan(0);
498-
499494
// Verify drill members are inherited and correctly transformed to use View naming
500495
expect(countMeasure.drillMembers).toEqual(['OrdersSimpleView.createdAt']);
501496
expect(countMeasure.drillMembersGrouped).toEqual({

0 commit comments

Comments
 (0)