Skip to content
This repository has been archived by the owner on Jul 6, 2021. It is now read-only.

Display line number where pending was called in backtrace #25

Open
mattwynne opened this issue Mar 20, 2015 · 6 comments
Open

Display line number where pending was called in backtrace #25

mattwynne opened this issue Mar 20, 2015 · 6 comments

Comments

@mattwynne
Copy link
Contributor

De-scoped from #22.

example:

     Scenario:
           Given pending
             TODO: Step not yet implemented (Cucumber::Core::Test::Result::Pending)
             features/step_definitions/steps.tcl:2
             features/test.feature:3:in `Given pending'

       1 scenario (1 pending)
       1 step (1 pending)
@d-led
Copy link

d-led commented Jan 14, 2016

source locations in tcl are tricky. Here's my attempt. The frame level there will probably need some logic, as it's fine-tuned to the project set-up

@d-led d-led mentioned this issue Jan 14, 2016
@mattwynne
Copy link
Contributor Author

@jowers can you take a look?

@d-led
Copy link

d-led commented Mar 3, 2016

@jowers the updated version: in cucumber-tcl-wire that is more robust against frame level differences

@jowers
Copy link
Contributor

jowers commented Mar 23, 2016

Hi @d-led, thanks for the contribution on this.

I'll try to put together a test that we can try out - as you said, source locations can be tricky, and I'm finding that testing in a standlone file is returning locations one level out at the moment. Probably best to see how it behaves within the cucumber code before I go investiigating that though.

@d-led
Copy link

d-led commented Mar 23, 2016

@jowers you're welcome! Here's the initial isolated investigation that lead to the code http://ideone.com/mdBT4s

upd: the only magic number left is the framelevel of get_location, which also could probably be robustly defined

@d-led
Copy link

d-led commented Mar 29, 2016

the shortcomings can be seen here: http://ideone.com/K5zZva

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants