Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gherkin/java: Use generated code instead of reading gherkin-languages.json #1957

Closed
mpkorstanje opened this issue Apr 18, 2022 · 0 comments · Fixed by #1959
Closed

gherkin/java: Use generated code instead of reading gherkin-languages.json #1957

mpkorstanje opened this issue Apr 18, 2022 · 0 comments · Fixed by #1959
Labels
🐛 bug Defect / Bug ⚡ enhancement Request for new functionality

Comments

@mpkorstanje
Copy link
Contributor

🤔 What's the problem you're trying to solve?

Reading gherkin-languages.json requires the inclusion of a json library. To avoid poluting the class path this library has to be shaded. This makes in place upgrades (e.g. for security reasons) harder.

✨ What's your proposed solution?

Instead of reading gherkin-languages.json generate the code for a list of GherkinDialect objects. See for example https://github.com/cucumber/ci-environment/blob/cfedf95c90052b2db812a56851daf1a6f7d1f690/java/src/main/groovy/io/cucumber/cienvironment/CiEnvironments.gsp#L7-L13

@mpkorstanje mpkorstanje added 🐛 bug Defect / Bug ⚡ enhancement Request for new functionality labels Apr 18, 2022
@aslakhellesoy aslakhellesoy mentioned this issue Apr 19, 2022
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Defect / Bug ⚡ enhancement Request for new functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant