Travis: install Gemfile dependencies during 'install' step

This ensures that a failure to do so marks the build as 'errored'
instead of 'failed'. The former indicates a CI failure instead of the
latter which indicates a failure of the system under test.

Author: muggenhor

.travis.yml

@@ -42,6 +42,8 @@ addons:
 
 install:
   - if [[ "${TRAVIS_OS_NAME}" = "osx" ]]; then brew update && brew install ninja qt5; fi
+  - gem install bundler
+  - bundle install
   # TODO: Revert to the following line when https://github.com/okkez/coveralls-lcov/pull/9 is merged and released.
   #- if [ -n "${COVERALLS_SERVICE_NAME}" ]; then gem install coveralls-lcov; fi
   - if [ -n "${COVERALLS_SERVICE_NAME}" ]; then gem install specific_install && gem specific_install -l https://github.com/muggenhor/coveralls-lcov.git -b branch-coverage; fi

src/Regex.cpp

@@ -31,6 +31,7 @@ FindRegexMatch::FindRegexMatch(const boost::regex &regexImpl, const std::string
     if (regexMatched) {
         boost::smatch::const_iterator i = matchResults.begin();
         if (i != matchResults.end())
+            // Skip capture group 0 which is the whole match, not a user marked sub-expression
             ++i;
         for (; i != matchResults.end(); ++i) {
             if (i->matched) {

travis.sh

@@ -2,9 +2,6 @@
 set -e #break script on non-zero exitcode from any command
 set -x #display command being executed
 
-gem install bundler
-bundle install
-
 CTEST_OUTPUT_ON_FAILURE=ON
 export CTEST_OUTPUT_ON_FAILURE