Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Improve V7 migration guide regarding hook "After" result #1537

Closed
fmagaldea opened this issue Jan 13, 2021 · 0 comments · Fixed by #1692
Closed

[doc] Improve V7 migration guide regarding hook "After" result #1537

fmagaldea opened this issue Jan 13, 2021 · 0 comments · Fixed by #1692
Assignees
Labels
📖 documentation Improvements or additions to documentation

Comments

@fmagaldea
Copy link

Hi,

During the migration of my project from V6 to V7, I found at least 2 breaking changes in the hook "After".

Considering the code

After(async function(scenario) {
 ...
});

, then I detected the following 2 changes:

  • V6 scenario.result.retried > in V7 this boolean was renamed to scenario.result.willBeRetried
  • V6 scenario.result.status was previously a string, which value could be for example failed > in V7 is now a number, whose all possible values can be found in object Status that can be imported from cucumber const {Status} = require('@cucumber/cucumber');

It would be nice to have a more clear overview of all changes in this objects.

Anyway thanks for this great tool!

@fmagaldea fmagaldea changed the title [doc] Improve migration guide regarding hook "After" result [doc] Improve V7 migration guide regarding hook "After" result Jan 13, 2021
@aslakhellesoy aslakhellesoy added the 📖 documentation Improvements or additions to documentation label Feb 2, 2021
@davidjgoss davidjgoss self-assigned this Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📖 documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants