You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The former uses a third-party library as well. I think there is some duplication here, and it's confusing for contributors to understand what's doing what.
✨ Do you have a proposal for making it better?
Review in detail, refactor so there's a single source of truth for timing-related stuff. Possibly drop the third-party dependency now - I think we brought that in before performance.now() was a thing, so it might be a little redundant.
🤔 What's the problem you've observed?
We have two areas doing similar work in different places:
The former uses a third-party library as well. I think there is some duplication here, and it's confusing for contributors to understand what's doing what.
✨ Do you have a proposal for making it better?
Review in detail, refactor so there's a single source of truth for timing-related stuff. Possibly drop the third-party dependency now - I think we brought that in before
performance.now()
was a thing, so it might be a little redundant.📚 Any additional context?
Observed when working on #2086.
This text was originally generated from a template, then edited by hand. You can modify the template here.
The text was updated successfully, but these errors were encountered: