Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Follow symlinks when loading feature files #2043

Merged
merged 1 commit into from
Jul 7, 2020

Conversation

fobo66
Copy link
Contributor

@fobo66 fobo66 commented Jul 7, 2020

Fixes #2042

Describe the solution you have implemented
I've added option for walkFileTree method to follow symlinks and added tests for PathScanner that involve symlinks

Additional context
Add any other context or screenshots about the pull request here.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 86.197% when pulling 69671db on fobo66:follow-symlinks into b57b924 on cucumber:main.

@mpkorstanje mpkorstanje changed the title Make Cucumber follow symlinks when loading feature files [Core] Follow symlinks when loading feature files Jul 7, 2020
@mpkorstanje mpkorstanje merged commit b3763b9 into cucumber:main Jul 7, 2020
@aslakhellesoy
Copy link
Contributor

Hi @fobo66,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

  • ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
  • 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
  • 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
  • ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
  • 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

@mpkorstanje
Copy link
Contributor

Cheers. This looks al right!

@fobo66
Copy link
Contributor Author

fobo66 commented Jul 7, 2020

Thanks!

@fobo66 fobo66 deleted the follow-symlinks branch July 7, 2020 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JUnit runner doesn't follow symlinks
5 participants