-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core] Improve undefined step reporting #2208
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2208 +/- ##
============================================
+ Coverage 82.79% 82.94% +0.14%
+ Complexity 2340 2334 -6
============================================
Files 306 306
Lines 8319 8312 -7
Branches 764 767 +3
============================================
+ Hits 6888 6894 +6
+ Misses 1120 1112 -8
+ Partials 311 306 -5
Continue to review full report at Codecov.
|
mpkorstanje
force-pushed
the
improve-undefined-step-reporting
branch
2 times, most recently
from
January 23, 2021 18:58
338f21a
to
715181a
Compare
mpkorstanje
force-pushed
the
improve-undefined-step-reporting
branch
3 times, most recently
from
February 13, 2021 21:25
e994ef4
to
fd024de
Compare
mpkorstanje
force-pushed
the
improve-undefined-step-reporting
branch
from
February 13, 2021 21:45
fd024de
to
89b2ad6
Compare
The various ways to execute Cucumber report undefined steps inconsistently. Partially because different tools have different reporting needs. Nevertheless: When reporting per scenario the suggestion should include snippets for all undefined steps in that scenario. This applies to: - JUnit4 - TestNG - JUnit5 - Teamcity Plugin When reporting per test run the suggestion should include snippets for all undefined steps in the execution. This applies to: - CLI When printing snippets they should be copy-pasted into an IDE without further editing. This means individual snippets or groups of snippets should not be separated by spacers, text or anything else. Fixes: #2024
mpkorstanje
force-pushed
the
improve-undefined-step-reporting
branch
from
February 13, 2021 21:48
89b2ad6
to
558a17d
Compare
This was referenced Mar 9, 2021
Merged
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The various ways to execute Cucumber report undefined steps inconsistently.
Partially because different tools have different reporting needs. Nevertheless:
When reporting per step or scenario the suggestion should include snippets for all
undefined steps in that scenario. This applies to:
When reporting per test run the suggestion should include snippets for all
undefined steps in the execution. This applies to:
When printing snippets they should be copy-pasted into an IDE without further
editing. This means individual snippets or groups of snippets should not be
separated by spacers, text or anything else.
Fixes: #2024