-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Jakarta Cdi] Correctly cast the UnmanagedInstance values #2250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpkorstanje
force-pushed
the
jakarta-cdi-unmanaged
branch
from
February 27, 2021 23:13
a514cf8
to
6263146
Compare
mpkorstanje
force-pushed
the
jakarta-cdi-unmanaged
branch
from
February 27, 2021 23:40
6263146
to
0754285
Compare
Codecov Report
@@ Coverage Diff @@
## main #2250 +/- ##
============================================
+ Coverage 82.98% 83.01% +0.02%
- Complexity 2339 2340 +1
============================================
Files 307 307
Lines 8324 8324
Branches 768 768
============================================
+ Hits 6908 6910 +2
+ Misses 1111 1110 -1
+ Partials 305 304 -1
Continue to review full report at Codecov.
|
mpkorstanje
requested review from
dcendents and
rmannibucau
and removed request for
dcendents
February 27, 2021 23:49
dcendents
approved these changes
Feb 28, 2021
rmannibucau
approved these changes
Feb 28, 2021
This was referenced Mar 9, 2021
Merged
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2242 for Jakarta Cdi