Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Jakarta Cdi] Correctly cast the UnmanagedInstance values #2250

Merged
merged 1 commit into from
Feb 28, 2021

Conversation

mpkorstanje
Copy link
Contributor

Fixes: #2242 for Jakarta Cdi

@codecov
Copy link

codecov bot commented Feb 27, 2021

Codecov Report

Merging #2250 (0754285) into main (609f284) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #2250      +/-   ##
============================================
+ Coverage     82.98%   83.01%   +0.02%     
- Complexity     2339     2340       +1     
============================================
  Files           307      307              
  Lines          8324     8324              
  Branches        768      768              
============================================
+ Hits           6908     6910       +2     
+ Misses         1111     1110       -1     
+ Partials        305      304       -1     
Impacted Files Coverage Δ Complexity Δ
...ava/io/cucumber/jakarta/cdi/CdiJakartaFactory.java 96.96% <100.00%> (+6.06%) 10.00 <3.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 609f284...0754285. Read the comment docs.

@mpkorstanje mpkorstanje requested review from dcendents and rmannibucau and removed request for dcendents February 27, 2021 23:49
@mpkorstanje mpkorstanje merged commit cdab6a9 into main Feb 28, 2021
@mpkorstanje mpkorstanje deleted the jakarta-cdi-unmanaged branch February 28, 2021 10:15
This was referenced Mar 9, 2021
This was referenced Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cucumber-cdi2 ClassCastException on unmanaged instances
3 participants