-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UndefinedDataTableTypeException with Boolean #2611
Comments
If you point me in the right direction, I could probably open a PR to fix it. I didn't search much yet so I might be saying toal nonsense but would this relate to the types defined at cucumber-jvm/datatable/src/main/java/io/cucumber/datatable/DataTableTypeRegistry.java Line 27 in 823c380
|
Yeah. That's the right spot. Not sure why I never added booleans. Note that they should be replaceable to facilitate converters that work with other boolean strings like yes/no ect. That's what the cucumber-jvm/datatable/src/main/java/io/cucumber/datatable/DataTableTypeRegistry.java Lines 30 to 31 in 823c380
|
👓 What did you see?
Cucumber is not able to convert
DataTable
toMap<String, Boolean>
.It fails with following error:
✅ What did you expect to see?
To be honest, I'm not sure I personally expect Cucumber to handle this case. But I admit it would be nice to handle conversion to
Boolean
as other types are handled likeString
orInteger
for instance.📦 Which tool/library version are you using?
Cucumber Core 7.7.0.
🔬 How could we reproduce it?
📚 Any additional context?
The issue was actually raised on Scala implementation in the first place: cucumber/cucumber-jvm-scala#322
The text was updated successfully, but these errors were encountered: