Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eclipse JUnit reports success when there are no stepdefs #262

Closed
dgradl opened this issue Mar 19, 2012 · 6 comments
Closed

Eclipse JUnit reports success when there are no stepdefs #262

dgradl opened this issue Mar 19, 2012 · 6 comments

Comments

@dgradl
Copy link
Contributor

dgradl commented Mar 19, 2012

Although Cucumber has this notion of a yellow state for pending steps, these are treated as ignored but cucumber JUnit and the eclipse JUnit feature lists the steps as ignored, but the scenario and feature as green (successful). It would seem to me that they should list as failed.

@aslakhellesoy
Copy link
Contributor

Sounds like a duplicate of #196. Please request this to be re-opened if I misunderstood and this is not the case.

@dgradl
Copy link
Contributor Author

dgradl commented Mar 19, 2012

Well I saw that other ticket as well, but I didn't see what that had to do with the JUnit component, I thought it was referencing the CLI interface, since I'm not sure passing --strict to the Eclipse JUnit Launcher seems intuitive and I also believe the notification events (to RunNotifier) that JUnitReporter sends is the source of the inaccurate result. If you meant for that ticket to cover JUnit specifically, I just couldn't see it from the details.

@aslakhellesoy
Copy link
Contributor

In order to be consistent with the command line interface, undefined or pending steps (yellow ones) should not cause a failure unless running in strict mode. With JUnit this can be done with:

@Cucumber.Options(strict = true)

Well, once it's implemented that is.

Would that suffice?

@TrueDub
Copy link

TrueDub commented Apr 30, 2012

Has this been implemented for JUnit yet? It works well in the CLI.

@klausbayrhammer
Copy link
Contributor

Yes is is. See #284 for more details

@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants