Enable reproducible builds

[hboutemy]

🤔 What's changed?

see https://maven.apache.org/guides/mini/guide-reproducible-builds.html

⚡️ What's your motivation?

Reproducible Builds

🏷️ What kind of change is this?

• 🏦 Refactoring/debt/DX (improvement to code design, tooling, documentation etc. without changing behaviour)

♻️ Anything particular you want feedback on?

📋 Checklist:

• I agree to respect and uphold the Cucumber Community Code of Conduct
• I've changed the behaviour of the code
  • I have added/updated tests to cover my changes.
• My change requires a change to the documentation.
  • I have updated the documentation accordingly.
• Users should know about my change
  • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

---

This text was originally generated from a template, then edited by hand. You can modify the template here.

[mpkorstanje]

Hey thanks for wanting to help out!

Did you also test the reproducibility? We have some custom code generation and because support for modules in Maven is still very janky mvn clean verify does not result in a passing build. So I'm a bit puzzled how you would have achieved that.

It would also be nice if we could add this to CI to ensure we don't break it in the future.

[codecov]

Codecov Report

Merging #2641 (f758505) into main (b8035f6) will not change coverage.
The diff coverage is n/a.

❗ Current head f758505 differs from pull request most recent head 816076e. Consider uploading reports for the commit 816076e to get more accurate results

@@            Coverage Diff            @@
##               main    #2641   +/-   ##
=========================================
  Coverage     84.77%   84.77%           
  Complexity     2686     2686           
=========================================
  Files           322      322           
  Lines          9530     9530           
  Branches        903      903           
=========================================
  Hits           8079     8079           
  Misses         1120     1120           
  Partials        331      331           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[hboutemy]

Did you also test the reproducibility?

I tested the reproducibility by running:

mvn clean install && mvn clean verify artifact:compare

which is the first level of tests = 2 local builds

It would also be nice if we could add this to CI to ensure we don't break it in the future.

Reproducible Builds will be tested on future releases by https://github.com/jvm-repo-rebuild/reproducible-central

[mpkorstanje]

Looks good.

I've included the plugin version changes in cucumber-parent instead. This should avoid the need to manually set versions in this project.

The build will eventually pass once cucumber-parent arrives on Maven Central.

Do note that Cucumber-JVM depends on several components that are build elsewhere in the Cucumber org. These include:

• https://github.com/cucumber/tag-expressions
• https://github.com/cucumber/messages/
• https://github.com/cucumber/cucumber-expressions/
• https://github.com/cucumber/html-formatter
• https://github.com/cucumber/ci-environment
• https://github.com/cucumber/gherkin

Will you also make these reproducible?

[aslakhellesoy]

Hi @hboutemy,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

• ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
• 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
• 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
• ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
• 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber