-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generic annotation for @Given @When @Then @And #2705
Comments
I'd be happy to take a pull request that adds this. To do this it would probably be best to change the GenerateI18n.java so that in addition to generating a localized annotation for every |
hi @mpkorstanje, so I checked the Generatel18n.java today, and found out that actually I need to modify the Gherkin Dialect in order to add the |
You can find the code for Gherkin in cucumber/gherkin. What made you believe it was cucumber/gherkin-java? |
ahh I see, I thought it was gherkin-java after a google search with the keyword GherkinDialect.java |
Btw, updating I don't think you'd have to change cucumber-jvm/cucumber-java/src/codegen/java/GenerateI18n.java Lines 76 to 80 in 12c5029
|
🤔 What's the problem you're trying to solve?
When I create the journey scenario. I use the
*
syntax in .feature file instead of normal Given When Then And. But then in those step's step definition, the @given or @when @then @and annotation is not able to differentiate the Journey step and normal integration test steps.✨ What's your proposed solution?
I think another alias annotation for @StepDefinitionAnnotation is gonna be a good solution, it could be named either
@Steps
or@Journey
⛏ Have you considered any alternatives or workarounds?
For now I use @and as annotation for journey step
📚 Any additional context?
I don't know if we need to take into consideration for other framework that build on top of cucumber, because when I'm using Serenity, I think they already use @step for another purpose
This text was originally generated from a template, then edited by hand. You can modify the template here.
The text was updated successfully, but these errors were encountered: