Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JUnit] Fix swallowed exception #2714

Merged
merged 4 commits into from
Apr 29, 2023
Merged

Conversation

mpkorstanje
Copy link
Contributor

@mpkorstanje mpkorstanje commented Mar 23, 2023

🤔 What's changed?

Fixes: #2694

🏷️ What kind of change is this?

  • 🐛 Bug fix (non-breaking change which fixes a defect)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@mpkorstanje mpkorstanje force-pushed the junit4-fix-swalloed-exception branch from d74803d to 657fadf Compare April 28, 2023 10:34
@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Merging #2714 (9d5540e) into main (926d218) will decrease coverage by 0.02%.
The diff coverage is 97.14%.

@@             Coverage Diff              @@
##               main    #2714      +/-   ##
============================================
- Coverage     85.01%   85.00%   -0.02%     
  Complexity     2726     2726              
============================================
  Files           331      331              
  Lines          9565     9538      -27     
  Branches        914      914              
============================================
- Hits           8132     8108      -24     
+ Misses         1110     1107       -3     
  Partials        323      323              
Impacted Files Coverage Δ
...latform/engine/CucumberEngineExecutionContext.java 86.66% <ø> (ø)
...ucumber/core/runtime/CucumberExecutionContext.java 98.79% <93.75%> (-1.21%) ⬇️
...rc/main/java/io/cucumber/core/runtime/Runtime.java 93.13% <100.00%> (+0.03%) ⬆️
...unit/platform/engine/CucumberEngineDescriptor.java 100.00% <100.00%> (ø)
...unit/src/main/java/io/cucumber/junit/Cucumber.java 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@mpkorstanje mpkorstanje marked this pull request as ready for review April 29, 2023 12:16
@mpkorstanje mpkorstanje merged commit 38cd14d into main Apr 29, 2023
@mpkorstanje mpkorstanje deleted the junit4-fix-swalloed-exception branch April 29, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[JUnit] exception swallowed while running cucumber
1 participant