thread leak in cucumber.runtime.Timeout class

[volna80]

Hi,

If you set timeout for all your steps, and have a lot of scenarios. Cucucmber-jvm falls that it reaches the limit of running threads (the number is depend on OS).

The bug is in cucumber.runtime.Timeout class.

ScheduledFuture<?> timer = Executors.newSingleThreadScheduledExecutor().schedule(new Runnable() {

It creates every time new executor service, but never stop it.

As the result, the number of running threads is growing.

[aslakhellesoy]

Ouch! Interested in sending a PR with a fix?

[volna80]

Yep, will send it today

[ffbit]

Great thread!
Could you please send us an instruction on how to reproduce the described case?
Thanks in advance.

[volna80]

1. define a step

@when(value = "do nothing", timeout = 60000)
public void doNothing(){
//do nothing
}

2. write a lot of scenarios which use this step

When do nothing
When do nothing
.....
When do nothing

3. run it using
   @RunWith(Cucumber.class)
   public class RunCukesTest {
   }

Result: Use any java profing and see that the number of live threads are growing

[aslakhellesoy]

It's possible to count the number of threads with Thread.getAllStackTraces(). This could be leveraged in a test that counts the number of threads before and after and verifies that the number is the same.

[ffbit]

Thanks for the clarification.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.