fix for #283 ((before|after)_step aren't called when scenario outline's table is processed) #284
Conversation
…r's callbacks as regular step. To call not only step_name() and before|after_step_result(), but also before|after_step() ExampleRow.accept_expand() now calls visitor.visit_step().
|
Any chances this request will be reviewed? |
|
Thanks for this contribution! One question: how come the test includes the code for a Ze::Formatter when it's an exact replica of the debug formatter that ships with Cucumber? Couldn't you just use that one and make the test a lot simpler? |
|
Yep, agree, it is a good idea. Will change this during this weekend. |
|
I've simplified the test. |
|
@mattwynne |
|
If you have any secrets for getting toddlers to go to sleep so I get my evenings back, that would definitely help :) |
|
@mattwynne benadryl or nyquil ;) j/k |
|
@mattwynne time? ;) When they become older they will sleep all night long (until the moment when they will be even older and will not sleep all night again :) |
|
@mattwynne, |
|
Merged! |
|
Finally!!! Thank you very much! |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
As a fix I've changed ExampleRow.accept_expand() to call visitor.visit_step() instead of invocation of the step and call of visit_step_result()