fix for skipped scenarios appearing as failures in cucumber junit report #496
Conversation
|
Could you please provide test for the problem you are fixing. |
| @@ -127,21 +127,21 @@ def after_table_row(table_row) | |||
| private | |||
|
|
|||
| def build_testcase(duration, status, exception = nil, suffix = "") | |||
| @time += duration | |||
| @time += duration | |||
There was a problem hiding this comment.
looks like some indentation problem :( Could you please fix it.
There was a problem hiding this comment.
sure will fix this indentation issue, but just one question.
when i look at the whole file here https://github.com/ambirag/cucumber/blob/ab00d824bd4a29b81b53f24e882ba659cc3c2840/lib/cucumber/formatter/junit.rb , it looks fine without any indentation issue, also when i open my local copy in vi, i dont see any indentation issue. Only the above diff is showing it, can you help me here ?
There was a problem hiding this comment.
Most likely you use tabs. Please replace them with spaces.
| passed = (status == :passed || pending) | ||
| @builder.testcase(:classname => classname, :name => name, :time => "%.6f" % duration) do | ||
| if( passed == false && status != :skipped) |
|
@ambirag it looks like I'm not receiving notification when new commits are added to PR, could you please add comment here when you think PR is ready for review. Thanks in advance. |
|
@ambirag it looks like you have added test to our "legacy" suite (which we try to replace by specs and feaures). Could you please either create spec for the problem or feature under "features" directory instead. |
|
@os97673 i have fixed the indentation issues, working on the test now |
ghost
assigned
@ambirag the code looks fine for me as soon as you will add test I'll merge the PR |
|
@os97673 i've added a test in spec as of now |
|
I've merged changes to both trunk and 1.3.x, as soon as Travis completes verification will release 1.3.4 |
|
@os97673 thanks |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
i raised this issue here - cucumber/common#495
all details are available in the issue ticket 495