Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elixir gherkin parser implementation #1251

Merged
merged 23 commits into from
Dec 10, 2020

Conversation

WannesFransen1994
Copy link
Contributor

@WannesFransen1994 WannesFransen1994 commented Nov 17, 2020

Elixir gherkin parser implementation.

Work in progress. TODO list:

  • Refactor tests so that all the test run despite one failure. Also provide a nice "report" / output
  • Refactor project name
  • Integrate with monorepo (makefile ) structure
  • CICD integration
  • rsync integration (also for messages?)
  • Request review
  • Update github link in mix.exs
  • Update documentation (generated docs + quick overview readme.md)

@mpkorstanje mpkorstanje changed the title WIP: code that needs to be refactored (and reviewed) Elixir gherkin parser implementation Nov 17, 2020
@mpkorstanje
Copy link
Contributor

I've renamed the issue to be a bit more descriptive of what its about.

@marnen
Copy link

marnen commented Nov 17, 2020

Cool. Are you aware of https://github.com/meadery/white-bread (which is looking for a maintainer)?

@WannesFransen1994
Copy link
Contributor Author

Yes, though my goal (for now) was to create a completely conform implementation which can be easily maintained regardless of language. Hence the start with the messages library and the gherkin parser which uses berp for the grammar rules.

No doubt though that this library, together with https://github.com/cabbage-ex/cabbage, https://github.com/hauleth/watermelon and https://github.com/Ajwah/ex_cucumber/tree/master/apps/cucumber_expressions can be used to create an implementation that could be merged into the cucumber monorepo.
`
Though really, this is just a Gherkin parser. My goal was to create a parser which can be maintained by the cucumber community for people who decide to create a cucumber implementation for Elixir :)

@WannesFransen1994
Copy link
Contributor Author

I've added the makefile. Would you mind verifying this please @aslakhellesoy ? Thank you.

@WannesFransen1994 WannesFransen1994 marked this pull request as ready for review November 23, 2020 09:00
@WannesFransen1994
Copy link
Contributor Author

WannesFransen1994 commented Nov 26, 2020

Update TODO list:

  • rename project to cucumber_gherkin

@aslakhellesoy aslakhellesoy merged commit b13a53f into master Dec 10, 2020
@aslakhellesoy aslakhellesoy deleted the elixir-gherkin-implementation branch December 10, 2020 13:00
@aslakhellesoy
Copy link
Contributor

It's landed! https://hex.pm/packages/cucumber_gherkin

Thanks a lot @WannesFransen1994 💯

@alvivi
Copy link

alvivi commented Dec 17, 2020

I'm not sure if this is a good place to talk about this (or maybe opening an issue), but this library cannot be used directly from Hex because the resources/gherkin_languages.json file is not packed together with the library. I think that you need to add it to files field in the mix.exs's package section.

Happy to see this :) For now I will continue to use the old elixir parser

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants