Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*.razor files have executable permissions #291

Closed
jenisys opened this issue Oct 2, 2024 · 2 comments · Fixed by #310
Closed

*.razor files have executable permissions #291

jenisys opened this issue Oct 2, 2024 · 2 comments · Fixed by #310
Labels
🐛 bug Defect / Bug

Comments

@jenisys
Copy link
Contributor

jenisys commented Oct 2, 2024

👓 What did you see?

When I clone this repository on a UNIX systems,
several or all *.razor files have executable permissions.

This is not necessary (IMHO) and probably an artefact that BERP grammar generation normally occurs on Windows (or in the container).

EXAMPLES:

  • javascript/gherkin-javascript.razor
  • python/gherkin-python.razor
  • ...

✅ What did you expect to see?

The *.razor should not have executable permissions (best verified on a UNIX system, like: macOS, Linux, BSD, Windows WSL, ...).

📦 Which tool/library version are you using?

NOT RELEVANT, because this a development/maintenance issue of the Git repository.

🔬 How could we reproduce it?

On a UNIX system:

# -- USE: bash shell (or some other shell)
$ git clone https://github.com/cucumber/gherkin.git
$ cd gherkin
$ ls -laF javascript/*.razor
-rwxr-xr-x  $SOME_USER  $SOME_GROUP  $FILE_SIZE $FILE_DATE javascript/gherkin-javascript.razor*

📚 Any additional context?

No response

@jenisys jenisys added the 🐛 bug Defect / Bug label Oct 2, 2024
@youtux
Copy link
Contributor

youtux commented Oct 2, 2024

agree, it should not be executable

@mpkorstanje
Copy link
Contributor

I have no idea why these are executable either.

Feel free to make pull request. If it changes exactly this, it will be quick to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Defect / Bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants