-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for CancelToken? #365
Comments
I can't speak for the other contributors, but I can say I'm not too interested in becoming spec-compliant. If we were to become spec-compliant, we would almost certainly see a performance drop. |
The cancelToken proposal has been withdrawn. More here - tc39/proposal-cancelable-promises#70. |
Thanks @ospatil. @jasonkuhrt I believe I can safely say that the consensus of the core most.js team has been that we wouldn't support CancelToken until it had become clear that it would survive and become official. Now that the proposal has been withdrawn, it doesn't make sense to support it in the core lib. If someone needs support for it for some reason (CancelToken early adopters??), they can implement an external |
I discovered cancel tokens a mere few weeks ago, and now their out–ha. Sorry for the noise everyone. |
No worries, @jasonkuhrt. Yeah, I think the withdraw was surprising to most folks. I haven't seen a good explanation for the reasons other than "google objected". I wasn't personally a fan of the proposal, but it'd be nice to know the reasons. |
Hey,
Its probably too early to begin this in earnest but assuming
most
wants to play well in the spec-compliant world then would it make sense to add support forCancelTokens
(detail) in any special way?While
cancelToken.promise
is sufficient to feed combinators likeuntil
I wonder if anything special needs to be done on the error handling side to distinguish between a canceled stream versus a failed one.The text was updated successfully, but these errors were encountered: