[BUG] links in pages widget lost when exhibit page is edited

[elrayle]

Describe the bug

Every time I go to edit a page that has the pages widget on it all the links in that widget are just gone and have to be redone. This has happened in all the exhibits I have worked on and every time I go to edit a page with that particular widget on it. I have attached screenshots of the “before” (i.e. all the pages linked) and then what happens as soon as I go to Edit—(i.e. no links there).

To Reproduce

Steps to reproduce the behavior:

I assume the same will happen to you if you just click on Edit on a page that uses the pages widget since this has happened to me in all three exhibits I have worked on and every single time I have used the pages widget.

Expected behavior

I expected the links would be preserved if I went in to edit something on the page, just as with all the other widgets.

Additional context

Reported by Jenny Leijonhufvud

[elrayle]

Override of FeaturedPagesBlock #L28 was supposed to only remove pages that didn't exist, but it was actually removing all pages.

This happened because in check parent.exhibit.pages.exists?(v['id']) , v['id'] is the slug id (e.g. 'wild') instead of the record id (e.g. 3). exists? expects to receive a record id.

The following line that gets the thumbnail finds the page using parent.exhibit.pages.find(v['id']) which will find the page given a slug id.

This issue was fixed in Spotlight code, so the override was removed.

[elrayle]

Fixed by PR #379 - remove cloudfront; remove featured_pages_block override