You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jan 2, 2024. It is now read-only.
LibCal only provides hours for dates in the past within the current week
LibCal weeks begin on Sunday
This means that our still open from yesterday logic will always return false on Sundays. For the time being I've implemented it in a way that it fails gracefully -- no thrown errors to the public -- but just a heads up that this will lead to potential false negatives for any space that is open beyond midnight on Saturday evenings.
At the moment, we don't have any spaces tied to signage that meet this criteria, at least not for regular hours.
I fully expect that this will not be true during extended hours such as study periods and final exams.
Proposed Solution
Reach out to Springshare support to request that the hours API endpoint provides past hours for at least the past two weeks (or guarantees hours can be returned for today - 1?)
The text was updated successfully, but these errors were encountered:
I was able to confirm my original suspicion from #89 that:
This means that our still open from yesterday logic will always return
false
on Sundays. For the time being I've implemented it in a way that it fails gracefully -- no thrown errors to the public -- but just a heads up that this will lead to potential false negatives for any space that is open beyond midnight on Saturday evenings.Proposed Solution
Reach out to Springshare support to request that the hours API endpoint provides past hours for at least the past two weeks (or guarantees hours can be returned for today - 1?)
The text was updated successfully, but these errors were encountered: