Skip to content
This repository has been archived by the owner on Jan 2, 2024. It is now read-only.

Possible issue with the 100 record limit on the libcal API #168

Open
tit1 opened this issue Mar 5, 2020 · 1 comment
Open

Possible issue with the 100 record limit on the libcal API #168

tit1 opened this issue Mar 5, 2020 · 1 comment
Labels

Comments

@tit1
Copy link
Contributor

tit1 commented Mar 5, 2020

The makerspace was not updating and showing a reservation that was set for today. After further investigation i believe that because there are only 100 records returned from the API at a time the reservation has been dropped from the feed. I am attaching screenshots and the data currently being received from the API
JSON.txt
image
image

@tit1 tit1 added the bug label Mar 5, 2020
@cappadona
Copy link
Contributor

Hi @tit1. Thanks for reporting this. Playing catchup during my first week back. This definitely appears to be a symptom of the 100 limit bookings from the LibCal API. As I mentioned back in 1da732a (part of #73) when first bringing the Mann reservable LCD online in the Fall of 2018:

Bump limit on LibCal bookings API to 100 (max)

Default is 20. Noticed that a reservation for 270 was dropped from the
sign during the day. While bumping to the max provides us some leeway,
we will have to keep our eye on this and see if we still hit the ceiling
during peak semester activity.

Now that we have 32 reservable spaces in Mann (thanks to migrating over a majority of the study rooms), we're much more likely to hit up against this limit on a regular basis and should reconsider our approach to querying the LibCal API. One potential solution, is to once include the category when querying the API, although this will bring with it additional challenges...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants