Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Semver not applied correctly #3

Open
ozmodiar opened this issue Feb 2, 2016 · 0 comments
Open

Semver not applied correctly #3

ozmodiar opened this issue Feb 2, 2016 · 0 comments

Comments

@ozmodiar
Copy link

ozmodiar commented Feb 2, 2016

Hello

I noticed that between version 1.2.1 and 1.2.2 there was a parameter added in the ServiceInterface::searchSuggestions description. This seems to be an API breaking change and should cause the major number to go up instead of the patch number.

Please be aware that this can cause serious problems with users that use this library.

Thanks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ozmodiar